Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign highmem runner to beam_PostCommit_Python and to beam_PreCommit… #28719

Merged
merged 1 commit into from
Sep 28, 2023
Merged

assign highmem runner to beam_PostCommit_Python and to beam_PreCommit… #28719

merged 1 commit into from
Sep 28, 2023

Conversation

volatilemolotov
Copy link
Contributor

Need to move the beam_PostCommit_Python and beam_PreCommit_Java_GCP_IO_Direct jobs to highmem runners due to OOMKills

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 28, 2023
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit a4ee854 into apache:master Sep 28, 2023
2 checks passed
This was referenced Sep 28, 2023
Closed
Closed
@Abacn
Copy link
Contributor

Abacn commented Sep 28, 2023 •
edited
Loading

Now the gradle script could run successfully but EnricoMi/publish-unit-test-result-action@v2 publishing JUnit result fails. Is highmem cluster lacking some credentials?

https://github.com/apache/beam/actions/runs/6343376359/job/17231138918

stacktrace on the action:

2023-09-28 20:15:14 +0000 - urllib3.connectionpool - WARNING - Retrying (GithubRetry(total=6, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=15)")': /repos/apache/beam


Traceback (most recent call last):
  File "/action/publish_test_results.py", line 538, in <module>
    main(settings, gha)
  File "/action/publish_test_results.py", line 262, in main
    Publisher(settings, gh, gha).publish(stats, results.case_results, conclusion)
  File "/action/publish/publisher.py", line 188, in __init__
    self._repo = gh.get_repo(self._settings.repo)
  File "/usr/local/lib/python3.8/site-packages/github/MainClass.py", line 376, in get_repo
    headers, data = self.__requester.requestJsonAndCheck("GET", url)
  File "/usr/local/lib/python3.8/site-packages/github/Requester.py", line 456, in requestJsonAndCheck
    *self.requestJson(
...
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='api.github.com', port=443): Max retries exceeded with url: /repos/apache/beam (Caused by ReadTimeoutError("HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=15)"))

@volatilemolotov
Copy link
Contributor Author

It should not lack any. Plus its a Read Timed out so its not a credential issue.
Could be Github temporary issue

@volatilemolotov
Copy link
Contributor Author

Ok so its occuring again. Not sure why, could be some rate limiting or some issue with performance, it times out after 15 sec

@Abacn Abacn mentioned this pull request Oct 3, 2023
Closed
16 tasks
Abacn added a commit that referenced this pull request Oct 3, 2023
@Abacn
Revert "assign highmem runner to beam_PostCommit_Python and to beam_P…
7176b9d 
…reCommit_Java_GCP_IO_Direct (#28719)"

This reverts commit a4ee854.
@Abacn Abacn mentioned this pull request Oct 3, 2023
Merged
Abacn added a commit that referenced this pull request Oct 3, 2023
@Abacn
Revert "assign highmem runner to beam_PostCommit_Python and to beam_P…
f6b43ce 
…reCommit_Java_GCP_IO_Direct (#28719)" (#28804)

This reverts commit a4ee854.
@volatilemolotov volatilemolotov deleted the move_jobs_to_highmem branch October 24, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abacn Abacn Abacn approved these changes

Assignees
No one assigned
Labels
build Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volatilemolotov @Abacn